feat(ssm): AWS SSM Parameter Store (driver + provider + SDK-compat handler)#263
Merged
Conversation
Collaborator
Author
Code review — findingsMulti-angle review. Layering matches Secrets; locking correct; prefix-boundary matching correct; real-SDK tests assert value/version round-trip, path hierarchy, typed errors. Fixed ( Deferred (documented): |
Emulate AWS Systems Manager Parameter Store so the real aws-sdk-go-v2/service/ssm client works against cloudemu. - parameterstore/driver: portable ParameterStore driver interface - parameterstore: portable wrapper (recorder/metrics/ratelimit/inject/latency) - providers/aws/ssm: in-memory memstore-backed provider (versioning, labels, hierarchical paths, history) - server/aws/ssm: AWS JSON 1.1 handler dispatched on X-Amz-Target AmazonSSM.* - wired SSM onto providers/aws.Provider and server/aws Drivers/Register Operations: PutParameter (Overwrite + versioning), GetParameter, GetParameters, GetParametersByPath (Recursive), DeleteParameter, DeleteParameters, DescribeParameters, GetParameterHistory, LabelParameterVersion. Version/label selectors via ':' suffix. SecureString is stored as-is (no KMS); WithDecryption is a no-op. Tests: sdk_roundtrip_test.go drives the real SDK client against httptest, asserting typed responses and a typed ParameterNotFound.
Address review of #239: - LabelParameterVersion now rejects labels that start with a digit or with aws/ssm (case-insensitive), returning them in InvalidLabels instead of attaching them — which also stops a numeric label (e.g. "5") from being attached and then made unreachable by version-number selector resolution. - PutParameter's Overwrite-race retry now uses the caller's context instead of context.Background().
NitinKumar004
force-pushed
the
feat/ssm-parameterstore
branch
from
38f64c5 to
bdd3466
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #239. New
parameterstoredriver +providers/aws/ssm+server/aws/ssm(AWS JSON 1.1,AmazonSSM.*). PutParameter (Overwrite/versioning), GetParameter(s), GetParametersByPath (recursive), Delete, DescribeParameters, GetParameterHistory, LabelParameterVersion. Real-SDK roundtrip tests; fullgo test ./server/...green. Gaps documented (SecureString/KMS no-op, pagination, policies).